Nicholas Shahan comments

Results 111 comments of


                                            Nicholas Shahan

Confusing error message when dynamically calling a null value

We should add additional test cases to https://github.com/dart-lang/sdk/blob/7e86f2e71cdfa17761ae418ae471f49fb0b72269/tests/dartdevc/no_such_method_errors_test.dart

pkg/dev_compiler/test/expression_compiler/asset_file_system_test is flaky/failing

@annagrin Any idea what might be going on? Here is a log from a failing run: ``` --- Command "vm" (took 59.000160s): DART_CONFIGURATION=DebugX64 CHROME_PATH=/b/s/w/ir/cache/builder/sdk/third_party/browsers/chrome/chrome/google-chrome out/DebugX64/dart-sdk/bin/dart --enable_asserts -Dtest_runner.configuration=unittest-asserts-debug-linux --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.dart_tool/package_config.json /b/s/w/ir/cache/builder/sdk/pkg/dev_compiler/test/expression_compiler/asset_file_system_test.dart...

build_runner + dev_compiler tests have become flaky on github actions

While doing some debugging on the change that @Markzipan mentioned it looked like we were missing some of the "Undetermined Nullability" erasure that we were attempting to perform so I...

build_runner + dev_compiler tests have become flaky on github actions

Is there a way I can debug the test running in chrome locally?

build_runner + dev_compiler tests have become flaky on github actions

I've been investigating and debugging but nothing jumps out at me as an obvious error. Finally I tried building at 2.18.0-238.0.dev and 2.18.0-250.0.dev and diffing all the files under the...

build_runner + dev_compiler tests have become flaky on github actions

I did a little digging and I think that all dev releases are uploaded to cloud storage, but not all are signed so they don't appear as available in the...

build_runner + dev_compiler tests have become flaky on github actions

@Markzipan! You just pointed out something that is so confusing but does add some explanation to what is going on so thank you!!! I have been looking at [this view](https://github.com/dart-lang/sdk/commits/dev?after=bc60bc5cecc48b4531c44a984d494b91888658c9+419&branch=dev&qualified_name=refs%2Fheads%2Fdev)...