Nicholas Shahan
Nicholas Shahan
@jezell Thanks for the helpful report! @sigmundch I agree with your assessment. The code referenced here is only run in DDC. If dart2js has a problem finding the interceptor for...
I'm not opposed to the idea, but I am more curious why you are not just using the exposed builder?
I am reluctant to expose it since it will legitimize adding a dependency on sass_builder for packages that only want to reuse the Importer. By adding the dependency you are...
I'm thinking for now that if we move it out of lib/src we just recommend that anyone depending on the package just to import that file should disable the sass_builder...
@srujzs and I did an investigation today and here are some notes: The `.toDart` getter call here is throwing: https://github.com/flutter/engine/blob/23467e04433d848ed5e074b0997a1be9296e4077/lib/web_ui/lib/src/engine/canvaskit/native_memory.dart#L25 The getter implementation is here: https://github.com/dart-lang/sdk/blob/74baf5e75a754edff091785586214549124c0c18/sdk/lib/_internal/js_shared/lib/js_interop_patch.dart#L95-L102 The getter does some...
There is a pattern in DDC that tickles this issue every once and a while when I'm missing a comma between two adjacent string arguments and they accidentally become adjacent...
@sgrekhov I've noticed that these tests are flaky for dart2js and DDC when running on Firefox and Safari even though they all use the TouchEvent constructor which is not present...
> How did you determine they are flaky? I keep seeing them turn our bots red from time to time when they change from `flaky -> RuntimeError`. > Did they...
AFAIK @elliette discovered and fixed the problem we had with our `dart:developer` logging implementation. I'm only not 100% sure it is fixed because I was never actually able to reproduce...
I meant a mono repo that forces a common set of dependencies pinned to the same version for all of the sub-packages. This is what the Dart SDK and Flutter...