Qi Ni

Results 63 comments of Qi Ni

It looks it is hard to fix as this is a restriction of ARM.

@chmill-zz the test coverage drops a little. Is it possible to enrich it?

/azp run kubernetes-sigs.cloud-provider-azure.basic_lb

/azp run kubernetes-sigs.cloud-provider-azure.basic_lb (run_basic_lb_e2e create_aks_cluster_and_run_tests_job)

@AfrouzMashayekhi thanks for the contribution! 1. Please add an E2E test. 2. If the check of spec.LoadBalancerIP is fully deleted, a lot of existing clusters will be broken. We need...

I would suggest the annotation overweights the service spec, if both are set at a time.

> I feel a wrapper to get service LoadBalancerIP might be a solution: `getServiceLoadBalancerIP()`: > > ``` > if annotation is set: > return annotation value > return service.spec.LoadBalancerIP >...