cloud-provider-azure
cloud-provider-azure copied to clipboard
kubernetes-sigs
Resetting the client before ARM throttling happens to avoid throttling
What type of PR is this?
/kind bug
What this PR does / why we need it:
ARM throttling is different than Azure RP throttling. Described here https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/request-limits-and-throttling
To avoid the instance level throttling per hour we should be able to reset the client to reset which instance we are communicating with on the ARM side. This will avoid ARM throttling.
Today we stick with the same instance and can hit throttling unnecessarily.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: chmill-zz (d53bd6951c9c277cdc047ba112c3df975264ea48, 8d986ec2d3a677ad8017784b2d36ea051ec65820)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for kubernetes-sigs-cloud-provide-azure ready!
| Name | Link |
|---|---|
| Latest commit | 8d986ec2d3a677ad8017784b2d36ea051ec65820 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/62c79c4757848f0009f92215 |
| Deploy Preview | https://deploy-preview-1997--kubernetes-sigs-cloud-provide-azure.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for warm-cascaron-bb779f ready!
| Name | Link |
|---|---|
| Latest commit | 8d986ec2d3a677ad8017784b2d36ea051ec65820 |
| Latest deploy log | https://app.netlify.com/sites/warm-cascaron-bb779f/deploys/62c79c47bae3b6000a33239f |
| Deploy Preview | https://deploy-preview-1997--warm-cascaron-bb779f.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Welcome @chmill-zz!
It looks like this is your first PR to kubernetes-sigs/cloud-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/cloud-provider-azure has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @chmill-zz. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: chmill-zz
To complete the pull request process, please assign nilo19 after the PR has been reviewed.
You can assign the PR to them by writing /assign @nilo19 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Coverage decreased (-0.2%) to 79.543% when pulling 8d986ec2d3a677ad8017784b2d36ea051ec65820 on chmill-zz:handleArmThrottling into a756b8e6c99b7a8e895169fffdbbe3b84ad88110 on kubernetes-sigs:master.
@chmill-zz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb | 8d986ec2d3a677ad8017784b2d36ea051ec65820 | link | true | /test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@chmill-zz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb | 8d986ec2d3a677ad8017784b2d36ea051ec65820 | link | true | /test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@chmill-zz: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@chmill-zz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb | 8d986ec2d3a677ad8017784b2d36ea051ec65820 | link | true | /test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb |
| pull-cloud-provider-azure-check | 8d986ec2d3a677ad8017784b2d36ea051ec65820 | link | true | /test pull-cloud-provider-azure-check |
| pull-cloud-provider-azure-unit | 8d986ec2d3a677ad8017784b2d36ea051ec65820 | link | true | /test pull-cloud-provider-azure-unit |
| pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz | 8d986ec2d3a677ad8017784b2d36ea051ec65820 | link | true | /test pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz |
| pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz | 8d986ec2d3a677ad8017784b2d36ea051ec65820 | link | true | /test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz |
| pull-cloud-provider-azure-e2e-ccm-vmssflex-capz | 8d986ec2d3a677ad8017784b2d36ea051ec65820 | link | true | /test pull-cloud-provider-azure-e2e-ccm-vmssflex-capz |
| pull-cloud-provider-azure-e2e-ccm-vmss-capz | 8d986ec2d3a677ad8017784b2d36ea051ec65820 | link | true | /test pull-cloud-provider-azure-e2e-ccm-vmss-capz |
| pull-cloud-provider-azure-e2e-capz | 8d986ec2d3a677ad8017784b2d36ea051ec65820 | link | true | /test pull-cloud-provider-azure-e2e-capz |
| pull-cloud-provider-azure-e2e-ccm-capz | 8d986ec2d3a677ad8017784b2d36ea051ec65820 | link | true | /test pull-cloud-provider-azure-e2e-ccm-capz |
| pull-cloud-provider-azure-e2e-ccm-vmss-shared-probe-capz | 8d986ec2d3a677ad8017784b2d36ea051ec65820 | link | true | /test pull-cloud-provider-azure-e2e-ccm-vmss-shared-probe-capz |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten