Norbert de Langen

Results 392 comments of Norbert de Langen

@MichaelArestad would you mind looking at the chromatic changes?

@tobiasljungstrom Sorry for the long delay! 😞 It seems like the button in shown in this story, when it shouldn't: https://www.chromatic.com/test?appId=5a375b97f4b14f0020b0cda3&id=632105a2ff4ffcc9270114e0 Is this something you could investigate?

I took a look at this and something is breaking: ``` FAIL lib/core-server/src/utils/stories-json.test.ts useStoriesJson JSON endpoint ✓ scans and extracts index (23 ms) ✓ scans and extracts stories v3 (11...

@ghengeveld please take a look at this? @jh3y Thank you for keeping with this PR, I have to defer to @ghengeveld and @MichaelArestad for these types of UX changes. I...

@jh3y Looks like some CI things are failing after i merged in the base branch. Do you recon you could have a look to see if you could fix that?...

good life stuff, I hope!

@jh3y @ghengeveld Is this PR salvageable? Can this be merged still? It's likely that the code has changed a lot since?

Both the linting error and the unit-test failures are correct. in `lib/core-client` direct references are made to files deep in the `dist` folder of `lib/preview-web`. Moving the bundling breaks this....

@javier-arango I finally was able to get to this, but to not have to deal with merge conflicts I created a new branch off `next` branch. https://github.com/storybookjs/storybook/pull/19655 I'm sorry that...