Norbert de Langen
Norbert de Langen
not for a while @yannbf, I'll get back to this later. I did create these: https://github.com/storybookjs/storybook/pull/18848 https://github.com/storybookjs/storybook/pull/18851 In an attempt to pave the way for this to land some day....
Thanks for this @blakegearin, I invited you into the org
Do we want to put this in v6.0.0? If we're not doing this now, it'll be 7.0.0 at the earliest.
@tmeasday @shilman WDYT, should we push this forward for 6.0.0 or delay for 7.0.0?
@shilman this is something we pushed to 7.0 back in the day. I resolved conflicts and it's ready to be reviewed again now. Are we going to commit to doing...
Why would rendering portals be influenced by this change @ghengeveld ? I'd rather not introduce feature flags for things we want to remove inside of a breaking change release, that...
What pain do you think users or us storybook maintainers would endure if we pushed this into 7.0?
So the possible foreseeable pain for users is re seeing to portals that target #root. That's an anti-pattern anyway, because that can't work for docs. So I think breaking that...
So we need 2 things to get this merged/ready for release: - chromatic needs to be updated, otherwise we lose a very significant part of our testing strategy. @skitterm is...
@tmeasday @shilman @yannbf shall I merge this?