Mikk Margus Möll

Whoops. Thank you for your feedback! Indeed, the code could be more performant. The new implementation is similar to your implementation in CoreDNS, with some small differences. I took the...

Is there still something wrong with this PR?

To my knowledge, NSEC is the only use for ordering records. Though as it is often referred to as canonical ordering and there are no other methods of ordering records...

Is there still something for me to fix in this PR? NSEC `Cover()` was already (though broken) part of the API before being removed in 2017. Is adding RFC4034 comparison...

> CompareDomainName already exists, we can't have two compare function in this lib. So one is wrong It has the description: > CompareDomainName compares the names s1 and s2 and...

> [...] it should be possible to use the `equal` function there to make it work with non-lowercased strings? So, comparing the labels, right to left, up until the rightmost...

Whoops yet again... I believe this should be what you described, code-wise. Also updated the tests slightly (the uppercased parts from the RFC4034 examples for `Compare` and the end of...

Just noticed that the `dddToByte` in this repo and the one in coredns are slightly different...

The last change might be controversial and I can revert it if you deem so fit. It does a bit of extra work in `Compare` so that , for names...

> Thanks for doing that. But can you explain why "equal" isn't good enough? Is it broken? I prefer not to have two comparison functions in there, but happy to...