Mikk Margus Möll

Results 19 comments of Mikk Margus Möll

@miekg I've procceeded with the "make `equal` a wrapper for `labelCompare`" plan, do you see anything still wrong with this PR?

> From a quick glance `equal` and `labelCompare` don't appear to normalise escape sequences. (Eg: `\097` and `a`, or `\a`, and uppercase variants thereof should be equal.) Should they, or...

I believe this is because one of your feeds has mapped `extra.source` to a text value, while others like Shadowserver and CTIP use values like `extra.source.sector` and `extra.source.connection_type`, which expect...

It would also implicitly fix the issue outlined in PR https://github.com/yl2chen/cidranger/pull/30 and issue https://github.com/yl2chen/cidranger/issues/42, as `net/netip` handles IPv4-mapped IPv6 addresses far better than `net`.

> After finishing working on TLDR-2, I (of course) found that @monoidic has also created a fork named TLDR2 at https://github.com/monoidic/TLDR2. He is also using an hourly GitHub action, and...

> Right now I'm looking at using parts of the "unique" pseudo address space to occupy the padding locations in structures. I tried this already and got this exception: `ghidra.util.exception.InvalidInputException:...

> Where do you think the problem originates from? The `type Connection struct` (defined [here](/sijms/go-ora/blob/159a50d7de09c798324a0d5a5635f1f6f1de5f54/v2/connection.go#L77)) is left "ungarbled", including the fields of `maxlen`, a field of `Connection` defined to be...

@Heat-Miser @gaelmuller @garanews @udgover Any thoughts?

I also updated the abuse address regex to make it ignore trailing dots, which pop up for some IP addresses. For instance, the results for `40.121.0.1` are `['[email protected].', '[email protected]']`