Matthew Draper

Results 128 comments of Matthew Draper

Thanks! I was able to reproduce this by just installing `better_html` on its own using edge ruby: it looks like the nokogiri platform / ruby-version compatibility combo isn't being handled...

So, my obvious concern is going to be that while Rails now has access to APIs to do its own parameter parsing, no existing releases are actually doing that. I...

> this is the standard format for generating forms in Rails No, it is not. I'm very surprised that format has ever parsed predictably. I guess we'll need to dig...

https://guides.rubyonrails.org/form_helpers.html#understanding-parameter-naming-conventions > `name="person[address][city]"`

`parse_query` gives no meaning to the content of the field names, so it returns a flat hash containing the names as supplied (including `[` and `]` characters). That's the RFC-matching...

> However, I'm not sure trying to support `{"article_version"=>{"body[answer1]"=>""}}` is worth the complexity it would entail. Yeah, that would be a fully new feature, and I don't think that's worth...

FWIW, I continue to insist that this is inherently a "no longer Rack" level of API breakage, because it assumes everyone is accessing `env` through the same `Request` instance, or...

My concern is here: > tell users they are on their own if ~they~ _someone else_ modifies rack.input or QUERY_STRING

@LitalFiverr I'd guess you're seeing a somewhat different compiler error... more like http://stackoverflow.com/questions/20051330/cant-install-ruby-gem-johnson, perhaps? What's your ruby version?

> I added .vscode to .gitignore; please let me know if that's acceptable Per the comment at the top of that file, it is not.