Matthew Draper

Results 128 comments of Matthew Draper

My plan involves c-r providing a low-level API (which Rails would call), to say essentially "please wrap every future-execution with this block" (the executor), and possibly another to wrap the...

@edwardmp maybe you have entries in `autoload_paths` that aren't in `eager_load_paths`? :confused: If everything is eager loaded, there shouldn't be anything left to autoload.

[Yes](https://github.com/rails/rails/blob/56c1326abb11ed275f04b6e0592ca66975e37f24/railties/lib/rails/application/finisher.rb#L190-L191): http://guides.rubyonrails.org/upgrading_ruby_on_rails.html#autoloading-is-disabled-after-booting-in-the-production-environment Also part of my confusion about how @edwardmp is getting far enough into the autoloader to see the "circular dependency detected" message.

From the documentation linked above, it sounds like `AllCops: NewCops: disable`, combined with explicitly disabling all default cops, might give a better experience, at the expense of having to carry...

Can these tests not use the separate standalone-chrome instance?

The binary won't be there on the machine running the test -- the point of the standalone image is that chrome runs in a separate docker image, and we communicate...

> So each build has a different image Yes, that's the image created by the `ruby:3.3` (etc) job, containing the current repo contents, the installed gems, and the built JS...

IIRC the explicit pull just separates the pull of the "build image" from the dependencies (postgres or whatever) into separate groups in the log output, so they get their time...

> To really optimize this, we'd need to make these image change less often (e.g. use a digest of the Gemfile.lock instead of the build id as tag). We do...

Yeah, the docker pull definitely takes a lot longer than I'd expect.. but IIRC so does the git clone :confused: (I do, as is my wont, have vague long-term plans...