Matthew Draper

Results 128 comments of Matthew Draper

Yeah, I think it makes sense to do this for all adapters. The SQL standard INTERVAL type is rather surprisingly limited (even beyond splitting into two incompatible types, it apparently...

At a glance this seems to have some strong overlap with #45071, which is perhaps a good sign that it's an idea whose time has come. Can you (cc @gwincr11)...

> What is missing here? API. I have some ideas, but haven't had a chance to revisit this yet. I really like the compactness for simple definitions I achieved here,...

While acknowledging that it's indistinguishable from public API, so not testable at the AR level, @kbrock can you see how practical it is to cover this with an Arel-internal test...

This behaviour seems very odd to me: given a `platforms :mri do` block, I'd expect any contained `platforms:` option to apply an intersection, not a union -- it seems weird...

This is a nice find! I had at one point suspected this was happening, but then failed to prove it. As @kaspth mentioned, it feels a bit awkward to maintain...

@JuanitoFatas I made a small tweak, building off the implementation you had in there ☝🏻 -- does it seem reasonable to you? As for testing... I haven't tried, but I...

@kaspth yeah I hit that too -- it definitely reveals some poor error handling 😅, but is because https://github.com/bkeepers/dotenv/pull/404 was merged. I didn't actually time things out, but in my...

> But I don't see Action Pack or any of the other gems mentioned? Ah, so this is another thing. Interesting! The output is missing because of this condition: https://github.com/gel-rb/gel/blob/d5e4aa3cc55d92c531dbee5b64e63b644a92b3ea/lib/gel/lock_loader.rb#L101...

I'd like to consider omitting the "relevant files" section... or maybe relegate it to a `--full` option or something. What do you think? I see the advantage in having a...