Ben Boeckel

Results 510 comments of Ben Boeckel

Well, it's broken because the dependent PRs haven't had releases yet. As for CI, yes there is, but you'll need to either use `rustup` rather than a plain base image...

I also have Cirrus CI scripts for minimal versions here: . Though it should really actually build with the minimal compiler version.

Seems that `trust-dns-resolver` is OK now. I did find one for `bin` that needs it, but `trust-dns-https` has other crates that need updates for `minimal-versions`, so I stopped there.

(This may be a core serde issue rather than an XML-specific one, but the toggle of behavior based on the presence of a `$value` field is in this crate.)

Thanks. I wonder if something like a `#[serde(keys=["kind_a", "kind_b"])]` attribute might make sense. Or to have some way to decorate the enum with a "tagged by key in the containing...

Agreed. The latter one probably makes more sense for such a level. The former sounds too XML-specific (since most other formats don't support multikey hashes).

Pinging @dtolnay in case you have any input here (in case a serde_derive change is feasible).

It'd be nice to be able to say "at the end of N episodes" as well.

> I believe this was a pre-existing issue, but using glslang on Unix requires Threads. If the user doesn't do find_package(Threads) prior to find_package(glslang), they get the following message when...

Until this is done, `WIN32 AND Debug` should probably error out.