Ben Boeckel

Results 510 comments of Ben Boeckel

Note that VTK's built-in wheel build will not change this fact (except that VTK now *really* wants to use GLVND if it is available).

Are you sure that it is the number of keys that is the problem? There are a few tests that test the max key size (usually one page) that trigger...

OK, seems that does correlate. Do you mind making some measurements as to where the limit should be for various `-j` settings to succeed with, say 80% probability? We can...

Thanks! A note in the README sounds good to me. CI already does one thread and it's all "the environment" which isn't something that should be poked at too much...

I've not played with trusted keys much, so ergonomics can certainly be missing. Maybe a `Payload::LoadHex` could be added for pre-formatted payloads? The current `Load` variant expects the raw bytes...

The "attach" APIs are also not used much myself either. They are used in the top-level `tests/` directory tests because there is some weird per-process logic going on there and...

https://doc.rust-lang.org/std/num/struct.NonZeroI32.html#method.new_unchecked is unsafe. I do like it better as a name, but the thing is that there's no way to know if a given ID is valid or not on...

FWIW, we're down to 6 `unwrap` and 3 `expect` calls outside the test suite. Unwrap calls: - parsing description bits as uid and gid (2 calls) - parsing permission bits...

> :( It appears the runners do not support encrypted keys... man_shrugging maybe place the tests or all of encrypted keys behind a feature? Yes, testing this stuff has been…painful...

> Note that this change now requires CONFIG_ENCRYPTED_KEYS to be enabled for unit tests to pass. #34 also has code to make tests into no-ops if a feature is not...