Ben Boeckel

Results 510 comments of Ben Boeckel

I've just merged #34 (with #39 as a TODO item) and some holes for tests when run as root. Please move the tests to the `encrypted.rs` file and use some...

http://ironframework.io/doc/libc/funcs/posix88/mman/fn.munlock.html

Hmm. It seems that by using `Cow` in the `KeyPayload`, the "take by reference" is always up to the user. I do see some potential holes: - `keytypes::encrypted::Payload::Load` is a...

Hmm. The caller using `SecBox` around the entire payload should be sufficient for `rxrpc`'s bits (since they're static-sized arrays). The `ticket` in `rxrpc::Payload` and other `Vec` bits should probably be...

Hrm. Returning a `Cow::Owned` moves the struct data back into a blob not in a zero-ing block of memory.

https://crates.io/crates/zeroize/1.0.0

https://crates.io/crates/secrecy

See https://github.com/compiler-explorer/infra/pull/1295 for infra updates.

I see no message in CI about what the failure might be :/ .