martin-mfg

Results 28 comments of martin-mfg

> Should this not be a MultipartFileResource? Good question. I used `org.springframework.core.io.Resource` because that's what other parts of the spring generator are using already for files. see e.g. [here](https://github.com/OpenAPITools/openapi-generator/blob/1751163f366e2890f16aad369604dc77801acc4b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java#L550) I...

SpringCodegen briefly used MultipartFile in the past, but then switched (back) to Resource. see #9555 for the change itself, and the links there for people encountering problems with MultipartFile. >...

The described issue still occurs in the latest master. Please note that the shown input spec uses `openapi: 3.1.0`, which isn't fully supported yet by OpenAPI Generator. see e.g. #9083....

> not sure what is missing, just rebased and reran step 3 and diff is empty I tried re-generating samples and can confirm that it doesn't generate any changes.

Hi @horaceli, using the `java` generator on the input from [my previous comment](https://github.com/OpenAPITools/openapi-generator/pull/18332#pullrequestreview-1999248530), with `library` set to "resttemplate" and `useBeanValidation` set to true, using your latest commit d1633af23ba28506dec6457bb94631ef7df20723, I get...

Hi, the changes look good to me. 👍 -------------- just some additional results from my experiments, in case this PR is referenced again in the future: - ```java String serialized...

It would be great if @wing328 or someone from the Java technical committee could take over reviewing this PR; both to add another perspective and because I currently can't work...

Thanks for the PR! It mostly looks good to me. But what is the intention behind `GenericTypeRef`?

The described removal of `@JsonTypeName("Animal")` happens since https://github.com/OpenAPITools/openapi-generator/pull/14733. cc @jorgerod

For anyone who wants to work on this: This bug needs to be fixed [here](https://github.com/OpenAPITools/openapi-generator/blob/742c2c48e75340d9eedf1276874bce9958cfea46/modules/openapi-generator/src/main/resources/JavaSpring/pojo.mustache#L262C48-L263C29). If the child model doesn't have any variables of it's own (i.e. `hasVars` is `false`),...