martin-mfg

Oh, I wasn't aware the javax problem affects so many different libraries. Good to have it fixed everywhere! > Re the generated API tests, I'll check again and get back...

Thanks for the input. I didn't have time to take a closer look yet, and this week I won't be available. But this PR is still on my to-do-list. Btw,...

Hi, I intended to make changes similar to those in [f91b1af](https://github.com/checkstyle/checkstyle/commit/f91b1af3d7c130daaeb52fea303b5d8e4c2769bf#diff-f1dcf2d250d8b52ccfbc408a657c47c4c735aef522b9c2f93c7826d93c152541), because of this comment: https://github.com/checkstyle/checkstyle/issues/3183#issuecomment-283539970. If I understand you correctly, `JavadocVariableCheck` should instead have such fields: ```java private AccessModifierOption...

regarding red CI: I'm not allowed to view any output from wercker, I only get "Hi, 401 - Unauthorized" when going [there](https://app.wercker.com/checkstyle/checkstyle/runs/build/602acc83c0593d001de1f0ea). Please tell me what is failing there. If...

Regarding the travis CI error, I created PR https://github.com/checkstyle/xwiki-commons/pull/15. On the one hand https://github.com/xwiki/xwiki-commons/pull/140 was opened directly in the original xwiki repo, on the other hand https://github.com/checkstyle/xwiki-commons/pull/14 was opened in...

@nmancus1 @romani, Is there anything I can do to get https://github.com/checkstyle/xwiki-commons/pull/15 turned into a new branch in [checkstyle/xwiki-commons](https://github.com/checkstyle/xwiki-commons)? I think that would be the next step necessary to merge this...

@romani I updated the travis and wercker builds and also created https://github.com/spring-io/spring-javaformat/pull/274, as you requested above. I also created https://github.com/xwiki/xwiki-commons/pull/143 as you requested in https://github.com/checkstyle/xwiki-commons/pull/15. I further created https://github.com/checkstyle/build-tools/pull/2 as...

Hi @romani, if I understand correctly, the access you requested is set by the checkbox in the bottom right corner here:  This has always been checked for this PR,...

@romani Regarding semaphoreci, I need someone to create a branch from https://github.com/checkstyle/build-tools/pull/2 please. Regarding xwiki, the main difference between the master branch and my branch seems to be that the...

@romani Regarding xwiki, I fixed the failing build by merging in the latest commits from the master branch at https://github.com/xwiki/xwiki-commons. To demostrate the build is working, I temporarily changed the...