Mark Dalgleish

Results 87 comments of Mark Dalgleish

We're experiencing this issue because we're executing our render code in a Node VM, which means we actually have multiple Object globals in memory and the `toString` equality check fails....

I can't reproduce this locally, even when using this HTML and running with exactly the same command line args. Would you be able to dig in a bit further to...

If that's the problem, we could definitely assert the existence of the file first.

Can you try [v0.5.2](https://github.com/seek-oss/html-sketchapp-cli/releases/tag/v0.5.2)? We just released a fix for our own timeout issue when using the `serve` option, which is quite probably related to yours.

Yeah, I was able to replicate this too. I'll have to find some time to dig into this a bit more and figure out what Sketch uses to decide whether...

I had a look into this recently and realised it's quite tricky, and depends on whether or not html-sketchapp is able to generate consistent IDs. Any thoughts on this, @kdzwinel?

IIRC Sketch maintains a reference to both the symbol ID and the *document ID*.

@kdzwinel not including a document ID in `document.asketch.json` makes sense to me. That threw me off for a while—I had to dig into the asketch2sketch source to realise that the...

@elliotdickison I'd say that hashing based on symbol name makes sense to me as a sensible default. In the long term, we could let you provide your own logic for...

This is not a pressing issue for us internally. If anyone can offer some help implementing this, that would be much appreciated.