Mark Dalgleish

Results 87 comments of Mark Dalgleish

Thanks for the PR! This looks really great. To me this is just an extension of our current `createVar` API. The fact that it's natively called `@property` definitely challenges our...

If our logic is correct you shouldn't be seeing this error. Would you be able to share a minimal reproduction?

@PrescottJRynewicz Thanks for providing a repro. I was able to work out the root cause of this issue and fix it here: https://github.com/remix-run/remix/pull/9305

Thanks for the bug report. I've reproduced the issue — even in our `dev` branch which now marks all Vanilla Extract files as having side effects, which I thought might...

In your example I was able to work around the issue by avoiding `export *` in `app/components/index.tsx` and explicitly re-exporting the component instead: ```diff -export * from "./Test"; +export {...

Version 0.17.7 introduced other tree shaking issues: https://github.com/evanw/esbuild/issues/2933

I'm closing this for now since it's an esbuild issue that can't be fixed in Remix. We've made a note of this issue in the [CSS bundling setup guide](https://remix.run/docs/en/main/guides/styling#css-bundling) to...

I wasn't able to reproduce this issue following your steps. Could you share a minimal repro?

@pcattori I've merged main into this PR with https://github.com/remix-run/remix/pull/9395 so usage of `?client-route=1` has been removed in dev.

Thanks for the detailed bug report and test case! Unfortunately this is actually [an issue with esbuild's CSS tree-shaking](https://github.com/evanw/esbuild/issues/1370) and not something we have control over. We're currently tracking this...