Results 186 comments of luukvbaal

BTW the motivation behind trying to merge it into core is that the "stabilization" done by the plugin is sometimes not fast enough in faster terminals. Thus resulting in flickering...

> * I think you should also add documentation. E.g. in `runtime/doc/quickref.txt` and `runtime/doc/options.txt`. Definitely. I refrained from doing so as I was still looking for general feedback on the...

> The etiquette is very much to contribute to Vim, I guess I'll do that then.

> (btw, does this imply we need a number or flags option instead of a boolean? because there are several possible behaviors.) Yes this makes sense, the option was also...

> Are you sure we would want this as default? Isn't the point of the scrolling to ensure the split doesn't cover the last position of the cursor? I'd contemplate...

I thought it could look something like the latest commit. Perhaps the solution is too naive though, I never use `scrolloff` so I'm not sure what to consider.

Vim upstream will consider the feature if we can agree on what it will do. They will require a test as well, `testdir/test_window_cmd.vim` seems appropriate. Will adding a test there...

> For that reason I don't think we should add a 3rd form of behaviour. I don't see any harm in adding the third option for those who prefer it....

I think I'll stop updating this PR until some movement happens in https://github.com/vim/vim/pull/10682. Furthermore it seems like we still haven't agreed on what the option should be so perhaps updating...

> We need to check if the cursor will remain in the window and obeys `'scrolloff'`. If it doesn't then we need to scroll appropriately, and not necessarily the old...