luukvbaal

Could I request some help writing a test? I'm not sure how to compose(/generate? when writing vim screendump tests they go to testdir/failed but I don't see that for lua...

> Could I request some help writing a test? Pushed the test I got so far. Added it in a new file `functional/test/number_spec.lua`. Again, not sure how to compose/generate the...

Ready for another round of review. Points of contention are: * Whether or not to provide new `'statusline'` expression format items specifically for `'cursorcolumn'` by assigning unused letters or overloading...

> * but we could also always set it to the appropriate value Below diff does that and uses ternaries instead, is it an improvement or only making it more...

Until now I had kept the `' '` separator between number column and buffer content. ~~Following diff allows you to do something like this instead:~~  On the topic of...

> Following diff allows you to do something like this instead: Hmm no this results in an offset between whats drawn and the actual cursor position. Not exactly sure how...

Reverted back to drawing over the previously drawn (empty) number column. I couldn't figure out how to shift the buffer content without drawing the default column first, running into the...

> Hmm, just realized %l can't be used within %{ } I wonder if we could get away with something like this: ```diff @@ -1131,6 +1131,17 @@ int build_stl_str_hl(win_T *wp,...

@bfredl I came across https://github.com/neovim/neovim/issues/14458#issuecomment-830429710 while looking through issues that this PR may fix. Does this feature interfere with/deprecate that plan at all? Or the other way around?

> We get things like highlighting, alignment, clickable elements(? untested) for free. Do we want click support for 'numbercolumn'? Trying it out as a POC and it's not free but...