Jan Šafránek

Results 222 comments of Jan Šafránek

StorageClass object was supposed to provide *classes* of storage ("slow", "fast", "secure"), not *configuration* of storage ("ssd-4-replicas-xfs", "ssd-4-replicas-ext4", "ssd-3-replicas-xfs"...) Why should user need to choose between say ext2 or xfs?...

I think volume attachment errors are available in `kubectl describe pod` (events on pods, not on PVCs).

In Pod events I can see: `Warning FailedAttachVolume 0s attachdetach-controller AttachVolume.Attach failed for volume "pvc-510f4944-e913-4af8-b20b-3e96ee7be428" : rpc error: code = Internal desc = unknown Attach error: failed when waiting for...

Indeed, detach errors are different - the pod that would be linked to the events already does not exists.I am not sure if it's correct to link them to a...

I find it odd that attach errors are sent to pods and detach errors would be PVC... I wonder if it's possible / common to send events to deleted Pods....

Alright, then the real fix should be in kubernetes/kubernetes. A/D controller sends events on volume attach errors [here](https://github.com/kubernetes/kubernetes/blob/df0af6f7b8f9b797d8fc7c0a9460cd02fbda7ce5/pkg/volume/util/operationexecutor/operation_generator.go#L436) and [here](https://github.com/kubernetes/kubernetes/blob/df0af6f7b8f9b797d8fc7c0a9460cd02fbda7ce5/pkg/volume/util/operationexecutor/operation_generator.go#L412-L418). And it does not send anything [on detach errors](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/util/operationexecutor/operation_generator.go#L526). I...

> Wouldn't that be kind of far from the error source? It is a generic place where all attach errors are reported and thus detach error should be there too....

> it could have an overriding effect to the regular timeout so that backwards compatibility is maintained. That seems reasonable, we will gladly welcome a PR.

/hold We should have a policy for all sidecars. Let's continue in https://github.com/kubernetes-csi/external-provisioner/pull/737

> What should happen is: > 1. ListVolumes() shows that volume is not attached to the node anymore > 2. We actually mark VolumeAttachment.status.attached as detached The volume might be...