Jan Šafránek comments

Results 222 comments of


                                            Jan Šafránek

do not delete the pv in the indexer cache store directly

/ok-to-test

Add dataSource label to pvcs created

/assign @gnufied Is it OK to add a new label to an existing metric?

Archive csi-driver-image-populator, csi-lib-fc, and csi-api repos

pkg/admission/storageclass: pick one storageclass conditionally if >1 present

@danishprakash, please add a release note `/approve` from sig-storage POV, but I have no approval power in admissions.

pkg/admission/storageclass: pick one storageclass conditionally if >1 present

/ok-to-test

pkg/admission/storageclass: pick one storageclass conditionally if >1 present

Unit tests are not happy: `FAIL: plugin/pkg/admission/storage/storageclass/setdefault TestAdmission (0.00s)`

pkg/admission/storageclass: pick one storageclass conditionally if >1 present

Sorry about the pain, we moved `getDefaultClass` to storage utils, but the implementation is the same as before.

pkg/admission/storageclass: pick one storageclass conditionally if >1 present

/approve from storage POV @thockin PTAL @danishprakash please add a release note in the first comment of this PR, this is user-facing change. See https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md#does-my-pull-request-need-a-release-note for details.

pkg/admission/storageclass: pick one storageclass conditionally if >1 present

/lgtm

Backward Compatibliity broken for RWO volumes

this has been briefly discussed in ReadWriteOncePod implementation PR: https://github.com/kubernetes/kubernetes/pull/102028#issuecomment-870091157