Jan Šafránek

Results 222 comments of Jan Šafránek

From external provisioner POV, it should be safe. In the worst case when both regular sync and ListVolume sync race, it marks just attached volume as detached. This causes VolumeAttachment...

It starts making sense now. I'm thinking if it can break anything in A/D controller. If A/D `VerifyVolumesAreAttached` finds a volume that is detached and the pod does not exist,...

I'd prefer to have a proper fix instead of piling up hacks in A/D controller & external-attacher. Node object is deleted. `PodGCController` deletes pods from the node. Should it delete...

> concerns about using the volumeattachment.status.attached field to indicate that a volume is detached because it could also mean attach or detach could be in progress The only signal that...

I am not sure about this. HTTPS is not only about encryption. See https://github.com/kubernetes-csi/external-attacher/pull/331#issuecomment-965015345

I agree with @humblec, PV and PVC is a different object with a different purpose and blindly copying labels from one to the other is IMO bad. For example, copying...

It almost feels like there should be pvc.spec.persistentVolumeTemplate, at least with annotations and labels. And perhaps with a way how to transform _some_ PVC fields into PV labels / annotations.

/remove-lifecycle rotten

/reopen /remove-lifecycle rotten