JP Richardson
JP Richardson
Sure. PR welcomed :)
I agree with this and think it's a wonderful idea. It's much more recognizable. To see it in action: https://github.com/jprichardson/node-klaw/blob/master/README.md
NACK. This library shouldn't bring in an bignum / bigint library as a dep. Ultimately it should just be a dumb parser and return a string for the number.
> returning a string was to ensure the precision of the numbers returned for values greater than 15 digits. The input data is a string. The output number would be...
https://github.com/cryptocoinjs/coinstring#deprecated-use-bs58check-instead :stuck_out_tongue:
I should mention that this package was created before `bs58check`... it's jut that it's a bit more confusing than `bs58check`.
Eeeks! Thanks for reporting! Fortunately I got it correct here: https://github.com/cryptocoinjs/coininfo/blob/master/lib/coins/btc.js#L62 I'll leave this open as a note to correct.
It was just a documentation error. I left this open to remind me to update the docs.
@goshva In the future, please open a new issue in the proper module. `coinstring` and `coinkey` are different modules. Also, sorry, I see that you referenced the docs, which are...
Hi @ErinSteph - thanks for dropping by. You use this module? Why would you not use `crypto.createHash`?