JP Richardson

Results 95 comments of JP Richardson

What's the URL you're passing to the module?

> Reviewing the code (and the error output) it has direct references to v8, maybe is it time to update it and use nan macros? Sure, sounds good. Any thoughts...

@foysavas thanks for taking the time to respond with your thoughts. Very helpful. Totally understand your position as well.

Wanna tackle this one too?

PR welcomed :) 2014-10-13 8:05 GMT-05:00 alexzaporozhets [email protected]: > var google = require('google'); > > google.lang = 'ru'; > google.tld = 'com.ua'; > > google('ПУЕТ', function(err, next, links){ > console.log(err,...

Certainly. Should modernize the code as well (separate PR)

@oorestisime would you be willing to put a test in place verifying that this actually fixes the problem? Thanks.

Couldn't a test harness be used to generate the files?

No doubt it's possible. Unfortunately I don't use the module much anymore, but will still accept PRs / maintain etc.

This would be cool :)