Joshua MacDonald

Results 335 comments of Joshua MacDonald

I would add a similar comment. The benchmarks that I did in Go show the logarithm costing in the 10-20ns range, while a table lookup could save half of that...

I've called this question a debate about an implementation detail. @MrAlias wrote: > I think the way the specification is currently defined it is ambiguous enough that both interpretations are...

> +1 for this, I was also confused when the predefined "delta" preference does not do all deltas (up down are not delta), or "stateless". It does a "hybrid" whatever...

@tigrannajaryan this is absolutely related, see also the update here https://github.com/open-telemetry/opentelemetry-specification/issues/1891#issuecomment-1309089908.

@nick-kentik When the next Satellite release is made (and in the future at Lightstep), https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/samplers/probability/consistent is now supported. This is the change needed, ``` diff --git a/pipelines/trace.go b/pipelines/trace.go index 46a7f28..1201978...

@cartersocha would you object to merging this change if we document it as an experimental feature that will not be ported to the other SDKs? I'd like to use this...

This repository will be deprecated soon and we cannot accept this PR, sorry. I hope the code snippet above helped.

Thank you @Oberon00 for raising this question, in connection with #484. I agree with the comments above that the flags of the span describe the span, not the parent. I...