Joshua MacDonald

Results 335 comments of Joshua MacDonald

https://github.com/apenwarr/redo works

For the record, the approach I've taken in the [Lightstep metrics SDK](https://github.com/lightstep/otel-launcher-go/tree/main/lightstep/sdk/metric) would require an exporter interface change to allow re-use of memory from one export to the next. For...

~This needs a bit more factoring work. I will move the lock out of the structure and add a Swap method to replace Move (requested by @paivagustavo).~

Because this uses Go-1.18 features, it makes sense to merge this to the `new_sdk/main` branch. OTOH, we have `sdk/metric/aggregator/exponential/mapping` already in place, and this builds on that work. If I...

~Needs to incorporate a tiny fix: https://github.com/lightstep/otel-launcher-go/pull/238~

I believe this is blocked until #3081 merges, since it depends on Go-1.18+ and cannot build with 1.17. Otherwise, ready to review.

Commit [e85aad4](https://github.com/open-telemetry/opentelemetry-go/pull/3022/commits/e85aad42d0bd4dab2d37c3621d16cb85a884e6e0) was a bit painful because there were many hand-crafted tests that were off-by-one in different ways after the inclusivity change #2982. I've resolved some of them by changing...

The specification definitely allows for it!

I think that OpenTelemetry may want to specify a behavior for SDKs to agree on and implement. The data model features "no data present" flags for each data point, which...