Javier Chávarri

Results 174 comments of Javier Chávarri

Updated the list in description to mark the modules updated in #331 as done.

ftr, updated the branch with latest `master` and merged #339 into the PR branch as well (thanks @maxlibin and @andrii-antiukhov for all the work!). I updated the list of components...

Remaining bugs: - [x] avatar image doesn't show when logged - [ ] error after logging in Warning: Can't perform a React state update on an unmounted component. This is...

Thanks @andrii-antiukhov @maxlibin @rusty-key !

BuckleScript does not exist anymore and I don't think we will have the resources to build a brand new Sketch engine for ReScript anytime soon, so closing related issues.

BuckleScript does not exist anymore and I don't think we will have the resources to build a brand new Sketch engine for ReScript anytime soon, so closing related issues.

I started looking into this and found some challenges, as the functions required to do this were not available back in 4.02.3: - `Location.warning_printer` was introduced in 4.03: https://github.com/ocaml/ocaml/commit/f9ea209cb7dd08634917e332aba8c61962bc5168 -...

BuckleScript does not exist anymore and I don't think we will have the resources to build a brand new Sketch engine for ReScript anytime soon, so closing related issues.

@thangngoc89 I am taking a look at this issue but I'm not sure I understand why the current BuckleScript implementation does not work. If users want to use `reason-react` then...

Thanks for explaining, that makes a lot of sense :) So how would this new code in `js_name_of_module_id.ml` differentiate between stdlib modules and other modules? Should we whitelist all module...