Javier Chávarri

Results 174 comments of Javier Chávarri

I tried building the template as it was, and also updated it [to latest commit](https://github.com/ml-in-barcelona/jsoo-react-template/commit/3fadd3371a425dc9193e8df3356eac03c0c16553) and I can't reproduce. 😕 Is the issue happening when running `make build` on the...

Adding here the great implementation ideas that @cristianoc proposed: pass a `slots` value around with some types + functions to allow each hook to read or write state atomically without...

@cristianoc One of the first questions that I have about your proposal is that the initial value of `slots` that needs to be passed to each component render function somehow...

Woah @cristianoc this is awesome!! I think there is now a clear path to add a `initialSlot` property to each instance, that will be stored and passed every time there...

@cristianoc @bryphe I've started implementing something in the [`slots`](https://github.com/revery-ui/reason-reactify/compare/master...jchavarri:slots?expand=1) branch (not much to see yet...), and I have one thought I'd like to share: After the latest changes towards the...

The main problem that I'm finding with the new slots-based model is that the value of `nextSlots` is always left as variable. This is failing when trying to unify types...

Aaah figured it out, it was exactly the second case you mentioned @cristianoc, I just had to ignore that type on the function signature, this example with direct style compiles!...

> As for obj.magic - rreason reactify needs it in "pushNewState" to handle hooks data I am aware. This is the whole reason why we're exploring the slots approach 😄...

@cristianoc Thinking about it more, one potential advantage of the continuation-passing style is that we could return the latest state value from the `use*` calls. This would kind of "close...

I'm running into an issue with the slots polymorphism. When reconciling, we need a way to set the "initial slot" to `None` for new instances, or pass the previous slots...