Jack Huey
Jack Huey
My only (soft) concern is that `collapse-macro-debuginfo` has not sat for very long (and I guess the no/external/yes options are also fairly new, but I'm less concerned about that). Is...
Test changes overall look fine, other than `gluon_salsa` that I have to think more about. Haven't really reviewed the code changes, but I'll do that soonish, since we have to...
Thinking about it: Is it worth distinguishing FCPs like *this* (i.e. FCPs about the team itself) from "typical" FCPs in regards to who is involved? I actually don't know the...
@bors try @rust-timer queue
Oops, I missed that you started a try/perf run before I did...
> Alright, changed it to `Ok(Ambig)`. As for refactoring, would it be useful to add `Solution::QuantumExceeded`, like `AnswerResult::QuantumExceeded` in chalk-engine? yeah probably @bors r+
This one I'll have to get back to
We talked about this today in a types team meeting (https://rust-lang.zulipchat.com/#narrow/stream/326132-t-types.2Fmeetings/topic/2022-10-07.20Planning.20meeting/near/302848792). We don't think we learn anything new from this issue (that isn't already a known limitation). We have ongoing...
Cool crate! I had expected to just use the flate2 decompress, but may try niffler instead (for the extra support). I'll work on getting this in this weekend - it's...
That seems fine - I did a bit of testing and didn't encounter any problems.