console icon indicating copy to clipboard operation
console copied to clipboard

Published 20 hours ago • verified publisher icon tokio-rs

Currently, the console only supports TCP, is there a plan to support Unix Domain Socket?

Open quanweiZhou opened this issue 3 years ago • 7 comments

quanweiZhou avatar Feb 25 '22 08:02 quanweiZhou

The console uses tonic as both the gRPC server (in the console-subscriber crate) and as the gRPC client (in the tokio-console command-line application). It looks like a PR to add Unix socket support in tonic was merged recently (https://github.com/hyperium/tonic/pull/861), but I don't believe it has been released yet. Once that PR is part of an upstream release of tonic, it should be pretty straightforward to add UDS support to the console.

hawkw avatar Feb 25 '22 20:02 hawkw

A new version was released 3 days ago, I believe that Unix socket support is in that release. Could this be looked at?

Milo123459 avatar Apr 07 '22 23:04 Milo123459

Yes, once we merge #318, it should be pretty easy to add support for Unix sockets. I've been out of the office for the last four days, so I haven't had the time to take care of that until today.

hawkw avatar Apr 08 '22 00:04 hawkw

Cool! Glad to know it's hopefully getting implemented soon.

Milo123459 avatar Apr 08 '22 00:04 Milo123459

@hawkw Currently the tonic 0.7 already supports UDS but the console doesn't seem to support UDS yet, am I missing something?

quanweiZhou avatar Apr 28 '22 04:04 quanweiZhou

Any updates? #318 was merged.

Milo123459 avatar Jun 05 '22 20:06 Milo123459

I haven't had the time to work on this, but now that Tonic 0.7 is out, it should certainly be possible and (I imagine) fairly straightforward. I'd happily merge a PR if anyone is interested in working on one.

hawkw avatar Jun 05 '22 22:06 hawkw