Grant Timmerman

Results 165 comments of Grant Timmerman

> If you look at the spec you linked, you will see that `traceparent` and `tracestate` are cloudevent attributes and the SDK will ignore protocall specific headers like `traceparent` as...

Thanks a bunch. I also found this sample, which is very useful. https://github.com/cloudevents/sdk-go/blob/main/v2/extensions/distributed_tracing_extension.go Will continue to test things on my side.

Yes, some of these points are nits/nice-to-haves. @n3wscott Are you not able to reproduce the issue of the sample not working?

Hey @n3wscott, I'd like to help our users have a better experience when using this SDK. I'm very thankful you've written the samples. The majority of the samples like http/receiver...

@ace-n Sounds like a python GCF testing best practice we can add to our python samples.

:+1: That would be sweet.

Thanks for the feedback. I think we should add that line too. I'll keep this issue open until that line is added.

Yup, sounds like cleaning up `additionalProperties: true` could be a good improvement to the schemas. I think we need to have our protos adopt the `optional` field for proto3 (3.15+)...

I'm not sure how to triage this issue. With JSON schema, each schema is self-contained and can iterate and evolve separately from other schemas. One of the things we can...

> @grant: I would suggest that we should ask each language owner to consider the developer experience and decide whether it's sufficient or not. > > The example I gave...