Grant Timmerman

Results 165 comments of Grant Timmerman

@lance I think this issue is complete? Anything else this issue is waiting on?

In terms of how a user uses this: A user should be able to add the HTTP header `traceparent: 01-asdfasdf-etc` and see the value within their CloudEvent receiver, such as...

I suggest not having this method imo. Keeping the interface as small as possible is really ideal in the long term. I deal with similar issues across consistency between implementations...

Thanks. Can you solve the DCO error?

Here's an updated link: https://github.com/cloudevents/spec/blob/v1.0.1/json-format.md#4-json-batch-format --- Given the number of providers that give batched events, I'm not sure if the SDKs are going to prioritize this format.

This is an example time attribute HTTP header: ``` ce-time: "2020-04-07T17:57:33.647Z" ``` https://github.com/cloudevents/spec/blob/v1.0/spec.md#time https://tools.ietf.org/html/rfc3339 Maybe `DateTime::createFromFormat` the property? I assume a type change would be a breaking change?

Sorry, can you be more specific? What is an expected command/feature that doesn't work right now? Within your function, you can log on all requests as normal. ```go log.Print("foobar") ```...

Oh, I don't think we have that feature, logging all requests, in the frameworks. We could add a sample that does that. We want to be careful of not logging...

A pull request / forked example would mean a lot in terms of understanding the change. If this feature isn't added to the framework, you can always [deploy your function...

I believe the CESDK should already support this, after you inject the tracing extension. Very rough code below: ```go import ( otelObs "github.com/cloudevents/sdk-go/observability/opentelemetry/v2/client" ) const ( TraceParentExtension = "traceparent" TraceStateExtension...