Grant Timmerman
Grant Timmerman
I think this is a generic warning that can be disabled in settings. I don't think it's specific to this library. Maybe send a PR if there's a change that...
Thanks for linking that issue @picaoao, something similar might work. Above is a PR.
> @grant any problems in going forward with the merge ? I need to talk to @grayside and figure out a solution that is appropriate for Go per a comment...
Comment from @picaoao in https://github.com/GoogleCloudPlatform/functions-framework-go/pull/63#issuecomment-762907726 > I think an optional env would be fine. > What do you think ? Hopefully we don't need to introduce an env var to...
Yes, the interface and devX should be better here. The core interfaces we expose are HTTP and CloudEvents. CloudEvents have 9 attributes, one being the CloudEvent `data`. Pub/Sub happens to...
Hey @jimmyff, I'm not super familiar with parsing JSON in Dart, but I think I updated that experimental type library to make it work. Basically, you need to parse the...
Why did you @grant me? 😕
I was looking and saw the description in pack: ``` Google: gcr.io/buildpacks/builder:v1 Ubuntu 18 base image with buildpacks for .NET, Go, Java, Node.js, and Python ``` But it looks like...
It's good seeing the `tests/integration` folder. Usually tests are right next to the code though and postfixed with `_test.go` right? I'd imagine basic samples to have tests. For the integration...
The sample parses a `ce-traceparent`, not `traceparent`. - Spec: https://github.com/cloudevents/spec/blob/master/extensions/distributed-tracing.md - Example: https://github.com/cloudevents/sdk-go/blob/main/samples/http/receiver-traced/main.go Example curl: ``` curl localhost:8080 -XPOST \ -H "Host: localhost:8080" \ -H "User-Agent: Go-http-client/1.1" \ -H "Content-Length:...