Nikita Shilnikov

Results 182 comments of Nikita Shilnikov

I'll be merging the PRs, I'll post-review them

They all look good at the first glance btw

Should we plan zeitwerk for 2.0 as well? I guess we should.

For the record, I've been running zeitwerk for 2+ months on production without problems

I see your point, Jeremy. But before taking any actions we must determine what is the ground truth here. Despite I worked with sqlite-jdbc through Sequel I dug straight into...

Good news! I figured that out: http://stackoverflow.com/questions/24500192/rake-aborted-sasssyntaxerror-undefined-variable-c-blue/24713907#24713907 Thank you @vike27 for your example!

I changed the error message in 4.0 btw https://github.com/rom-rb/rom/blob/7ed4ad8b030210692bc850ae8fbf3e293922b9e1/core/lib/rom/schema/inferrer.rb#L12-L19

I can see how this can be confusing but I doubt we can fix it in any way. "Fixing" would be a breaking change first of all. Second, I don't...

I don't see a good way. Good in the sense that matches the internals. You can hack it but hacking things often brings more problems than it solves. Types don't...