Nikita Shilnikov

Results 182 comments of Nikita Shilnikov

Just what I said lol https://github.com/rails/rails/commit/9ea15f1927393a88c0a5dbe250420b7afdfa6aed

Another thought (sorry for spamming): we should provide a way to fix the format to ISO8601. Mb it should be a different key, e.g. `:iso_time` and `:iso_date`. It'll be 💯...

> this methods is fast, but this is a very strict format logic, this methods throw exeptions, and for fallback we need handle it, but exeptions is very slow But...

I looked it up, seems like using `Date._strptime` or `Date._iso8601` would be faster and cleaner. I checked, they are even defined in JRuby. WDYT?

Thanks for this! A minor heads up. I benchmarked various options and looked into the ruby sources. It turns out that ruby itself relies on regular expressions internally. My benchmarking...

We'll need to generalize some internals for that. Maybe we could do it in 1.3

> Looks like it's not possible using dry-validation. Dependencies between fields _must_ be handled via rules, not through the schema dsl. `:bar` should always be optional, then you check its...

`?`-ending keys are not supported because they have special meaning in dry-types. It was a trade-off I made. We could have an option for schemas to avoid this in dry-schema,...

Different gateways use different connections by design, and joining across different connections is not possible. However, there's no check in the code ensuring you don't do that. The results you...