dry-schema icon indicating copy to clipboard operation
dry-schema copied to clipboard

Update config in configure blocks only

Open timriley opened this issue 3 years ago • 2 comments

Update all usages of dry-configurable-provided config so that any changes are made inside configure blocks.

This prepares for the changes in https://github.com/dry-rb/dry-configurable/pull/140.

timriley avatar Sep 22 '22 01:09 timriley

Oh but this means it should go to dry-schema 2.0.0 :/ Is it possible to actually maintain previous behavior?

solnic avatar Sep 22 '22 07:09 solnic

Just noting for the record that we discussed over in https://github.com/dry-rb/dry-configurable/pull/140 that we would:

make the type spec change (making them mandatory) and push 2.0 along with the configure change

timriley avatar Sep 24 '22 06:09 timriley

Should we plan zeitwerk for 2.0 as well? I guess we should.

flash-gordon avatar Sep 27 '22 07:09 flash-gordon

For the record, I've been running zeitwerk for 2+ months on production without problems

flash-gordon avatar Sep 27 '22 07:09 flash-gordon

Should we plan zeitwerk for 2.0 as well? I guess we should.

I say yes. Most of the work has been completed. It's a matter of releasing stuff and fixing any potential issues (😅).

solnic avatar Sep 27 '22 08:09 solnic