Edward Chernenko

Results 27 comments of Edward Chernenko

I also think that lower-tier abilities should be suppressed/removed if a higher-tier ability (of the same type) is present. Unit with absorbs(1) and absorbs(3) should have exactly absorbs(3), not 1...

"What attack will AI choose" can be prioritized by setting attack_weight= for the attack. There is no need to change the damage, etc.

> I believe attack_weight doesn't actually work correctly, except for zero vs non-zero. How about attack_weight=0 for fireball then?

> so they should be in the loti namespace and then grouped if they pertain more to units or to items Agreed. There may be other categories (e.g. I grouped...

The compact version does indeed help on large screens, but the price is readability of diffs. Examples are below. The thing is, there aren't many situations when we need to...

Very well. Feel free to rearrange the code of existing dialogs as convenient for you. Let's delay this on the `inventory` branch until it is completed and merged into master....

> when I'll need to edit it in some way. Note that this should be in a separate commit from functional changes. Not like "this 1 commit rearranges 50 lines...

Another code style difference I wanted to discuss is ```lua for i = 1,#array do many_lines_that_work_with(array[i]) end ``` vs. ```lua for i, elem in ipairs(array) do many_lines_that_work_with(elem) end ``` I've...

The problem appeared in the commit that replaced old stats.cfg with stats.lua. There was some logic related to this attack in stats.cfg (stats.lua doesn't have this). Although the code in...

It has nothing to do with `effects()`. Here is a simple test: 1) start Gladiators with Elvish Assassin, 2) do `:unit advances=1` to level it up, select "executing enemy bosses...