Edward Chernenko

Not yet. I want to write an automated test for it first (a Lua function that would create a test unit, add/delete/list some items/effects/advancements to it via this API, and...

I apologize for the delay. The branch is not ready for merge yet (the testsuite is far from completion, but already caught some errors, I fixed what I noticed so...

Question: why is `add_advancement()` applied to a specific unit? Isn't the list of advancements the same for all units of a certain type?

Testsuite now covers add_item(), add_advancement(), items() and advancements(). ``` $ loti.testsuite() Testsuite: running unitdata.test.lua PASS add/list advancements (on unit ID) PASS add/list advancements (on WML table) PASS list effects on...

Question 1: can we remove `get_type_advancement()` in `loti.unit.advancements()`? The unit itself has a copy of unlocked advancements (full WML tables of [advancement] tag), so isn't `get_type_advancement(unit.type, elem.id)` the same as...

There are also leftovers of `mods` variable in `update_stats()`, but I'll handle those. The merge (when ready) will be performed in two steps: 1) first unitdata.lua (+ testsuite) will be...

The script is in `.github/scripts/upload_beta_addon.sh`. Addon server is selected in the line ```bash for WESNOTH_VERSION in "1.16.x" "1.17.x"; do ```