Dirkjan Ochtman
Dirkjan Ochtman
I think we should use a basic console-based tracing-subscriber setup: ```rust pub(super) fn subscribe() -> tracing::subscriber::DefaultGuard { let sub = tracing_subscriber::FmtSubscriber::builder() .with_max_level(tracing::Level::TRACE) .with_writer(|| TestWriter) .finish(); tracing::subscriber::set_default(sub) } struct TestWriter; impl...
> > Get rid of all the opentelemetry dependencies, which I don't think we need > > Remove the use of the otel feature > > Remove the custom test...
> > Currently, helping out the Rustup team by enabling local tracing is quite a tedious process (esp. for community contributors), requiring rebuilding Rustup from the exact commit with an...
#3367 has been merged, would be good to rebase this!
Maybe try a branch where you apply https://github.com/rust-lang/rustup/commit/0cf0c6bdd35f9bf8076d78627eab0ee6f01e3a88 to 1.27.1 directly (or some other commit maybe from before #3868) to see if that works? It might be some "interesting" interaction...
> That being said, the overall `tracing` thing is working pretty well, so it might make some sense to leave [0cf0c6b](https://github.com/rust-lang/rustup/commit/0cf0c6bdd35f9bf8076d78627eab0ee6f01e3a88) for another PR. Oh yes, I'm in favor of...
> > Seemingly this has been fixed on main. I have added a regression test here: [#4040](https://github.com/rust-lang/rustup/pull/4040). > > [@lucacasonato](https://github.com/lucacasonato) Thanks for the heads up! This looks interesting. Maybe that's...
Given that `Cfg::get_profile()` should yield the default profile anyway, it shouldn't be a substantial change? It does feel more correct to initialize with `None` than `Some(Profile::default())`.
Hah, that makes sense.
Have you taken stock of open issues referencing being solved by reverting to the curl backend? Have you considered the alternative of using curl with the rustls TLS backend? (Note:...