Dirkjan Ochtman

Results 2159 comments of Dirkjan Ochtman

Sounds reasonable to make sure more of the `info:` output is omitted if `-q` is used. Want to submit a PR?

I think it would be fine to make `-q` more general and use a `LevelFilter::Warn` if it's enabled.

Agreed with @rami3l that it doesn't make much sense for us to review this. A more automated release process sounds good, I guess that's something someone from the infra team...

Also, many benefits from rustls just being more secure by default than OpenSSL.

I think a good approach here would be to add an integration test that can download a recent manifest, parse it, and regenerate a source file that contains current definitions...

Yeah, splitting is definitely not completely straightforward, but having an automated test that checks our internal code matches any targets in current manifests still sounds good.

Instead of using `include!()` or a procedural macro, IMO it would be better to have an integration test that writes into a source file inside `src` and can be imported...

Potentially -- but (a) fixing it should be very straightforward and (b) don't know how much the target moves. If you think using platforms is easier, I'd go with that...

Does it work if you set a `RUSTUP_USE_CURL=1` environment variable?