Ellen Shapiro

Results 100 comments of Ellen Shapiro

Any word on when this might happen? I'd love to be able to support watchOS without insanely hacky workarounds.

Thanks @bdorfman-stripe! For the most part this looks good, and philosophically only including the API bindings makes sense. A few issues I see here: - The podspec has not yet...

@bdorfman-stripe Wee check-in to see if you've been able to make any progress on this or if you would like some help making progress on this.

Weird! I haven't seen this at all. - Is this new behavior in `0.45.0` or was this also happening before? - You mentioned the app is in the foreground -...

Yeah that certainly sounds like it could be it. I can see arguments both ways in terms of baking it into Apollo or not: Theoretically the websocket is an implementation...

Looks like if you want to reopen the same connection, you should be calling `pauseWebSocketConnection()` rather than `closeConnection()` - close connection [sends a message completely terminating the socket before disconnecting](https://github.com/apollographql/apollo-ios/blob/45d382db52589b10d9ad3b42054a44e9180d23f8/Sources/ApolloWebSocket/WebSocketTransport.swift#L232),...

Ah yes, that's less expected then! From the code it does appear that you've got the `URLSessionClient` in a singleton so it shouldn't be getting hammered by ARC. Is this...

Yeah, I think the main reason I wanted to return a `Task` was not to need the optional, but realistically almost anyplace that's holding onto the task is going to...

Yeah not having to manually cancel would certainly be ideal, but I don't think that's how things are set up at the moment. I'll have to see how plausible that...

If it's being retained by the Apollo store, wouldn't `deinit` never get called?