Ellen Shapiro

When profiling using the `self.noReactiveTest` I was able to confirm that while it goes up to about 400 megs of memory usage, nothing is actually _leaking_, everything eventually gets deallocated....

@zebganzo I just filed #1683 which outlines a bunch of the problems underlying this performance issue. I think for now I'd prefer to track that as the long-term issue. If...

@PatrickDanino So basically adding the following to `cancel`: ```swift if let additionalHandler = self.additionalErrorHandler, let additionalCancelable = additionalHandler as? Cancellable { additionalCancelable.cancel() } ``` is what you're looking for, correct?

🤔 In general the requests are supposed to be pretty lightweight - what kind of data are you needing to clean up?

So we've had a separate request to start throwing cancellation errors when a request is cancelled (basically following the `NSURLSession` pattern). If we did that, then every time something was...

Yeah, definitely originally designed not to force every client to handle cancellation errors but after a lot of talking with folks now I see why Apple went that way with...

(except with the user not having to set anything up themselves 😇)

It's a little hard to do it with the associated types since each type is different per query to make sure you're only trying to use the specific type requested...

🤔 I'm gonna do some noodling on this and see what might be doable - I like where you're going with it though.

Honestly, it's because I haven't had time to get it to search recursively through a potentially infinite size of dictionary to replace a variable value with `null` in order to...