Sean Fitzgerald
Sean Fitzgerald
I'm seeing the following error message when depending on click 8.0.3, and I suspect that it's related. Drafting a PR now. ```sh $ ./piku.py ./piku.py:1113: DeprecationWarning: 'resultcallback' has been renamed...
https://github.com/piku/piku/pull/247
This was attempted (by me!) in early iterations of the stack. It was eventually deprecated because of quality issues, and migrated to the current implementation. TL/DR; this is behaving as...
As a start, it looks like the adapt [Parser](https://github.com/MycroftAI/adapt/blob/master/adapt/parser.py#L64) emits all of the tagged entities, which would include matching span info. Since the expander is stateless, it should be straight...
I think this is a mistake with the [Location regex](https://github.com/MycroftAI/skill-weather/blob/b0194125e2e03d010949ed6c89a8cf9ce7931141/regex/en-us/location.rx), probably in a few different skills. Regex entities are run against all possible subsequences of an utterance, meaning that they...
It's also worth calling out the en-us reged in date-time skill does not have this overmatching problem: https://github.com/MycroftAI/skill-date-time/blob/fdec596ec93638f30d04d01d7b2d3ce432fe732a/regex/en-us/location.rx
Hey @danielquinn , I actually [wrote](https://community.mycroft.ai/t/best-practices-to-secure-mycroft-messagebus/10186/6) about this topic at length a couple months ago. TL/DR; version: yup, there's work to do. Building something that supports the full ecosystem (in...
Sorry, just to clarify, this is dead in the water? A warning on the controller of "Hey, this doesn't work at all" seems kinda sub-awesome. Thanks!
Got it. I may try to capture the traffic as it goes past and see if I can pitch in, but that does mean closing my other 40 browser tabs,...