piku icon indicating copy to clipboard operation
piku copied to clipboard

Apparent issue with click 8.x

Open rcarmo opened this issue 3 years ago • 3 comments

Traceback (most recent call last):
[7](https://github.com/piku/piku/runs/5801674133?check_suite_focus=true#step:5:7)
  File "piku.py", line 1113, in <module>
[8](https://github.com/piku/piku/runs/5801674133?check_suite_focus=true#step:5:8)
    @piku.resultcallback()
[9](https://github.com/piku/piku/runs/5801674133?check_suite_focus=true#step:5:9)
AttributeError: 'Group' object has no attribute 'resultcallback'

Need to investigate this further since we have been relying on OS packages (which seem to be 7.x only)

rcarmo avatar Apr 02 '22 20:04 rcarmo

This issue is stale because it has been open for 90 days with no activity.

github-actions[bot] avatar Jul 02 '22 03:07 github-actions[bot]

I'm seeing the following error message when depending on click 8.0.3, and I suspect that it's related. Drafting a PR now.

$ ./piku.py 
./piku.py:1113: DeprecationWarning: 'resultcallback' has been renamed to 'result_callback'. The old name will be removed in Click 8.1.
  @piku.resultcallback()

clusterfudge avatar Jul 11 '22 16:07 clusterfudge

https://github.com/piku/piku/pull/247

clusterfudge avatar Jul 11 '22 16:07 clusterfudge

This issue is stale because it has been open for 90 days with no activity.

github-actions[bot] avatar Oct 10 '22 03:10 github-actions[bot]

This issue was closed because it has been inactive for 30 days since being marked as stale.

github-actions[bot] avatar Nov 10 '22 03:11 github-actions[bot]

Reopening this even though the PR is closed, because I suspect it will come up again with newer versions…

rcarmo avatar Jan 07 '23 23:01 rcarmo

Version 8.1 dropped support for Python 3.6 in March 2022. https://click.palletsprojects.com/en/8.1.x/changes/#version-8-1-0

ewalk153 avatar Jan 08 '23 14:01 ewalk153

This issue is stale because it has been open for 90 days with no activity.

github-actions[bot] avatar Jun 04 '23 02:06 github-actions[bot]

This issue was closed because it has been inactive for 30 days since being marked as stale.

github-actions[bot] avatar Jul 05 '23 02:07 github-actions[bot]