Andrew comments

Results 101 comments of


                                            Andrew

ProUI ExtUI | `EXTENSIBLE_UI`, fixes & cleanup

> PR #26563 added various ExtUI calls to Marlin/src/lcd/e3v2/proui/dwin.cpp, but this file does not have #include "../../extui/ui_api.h" > > resulting in Many errors > > ``` > Compiling .pio/build/STM32F103RE_creality/src/src/lcd/extui/ui_api.cpp.o >...

Add 4 axis CNC configuration for MiniRambo board

in **Marlin\src\inc\Conditionals_LCD.h** it does ` #undef TEMP_SENSOR_0 `, so in the configs ` #define TEMP_SENSOR_0 1 ` might as well be ` 0 `

Wrong menu text for adjusting Z probe offset

I agree "Update Probe Z-Offset to " is a bit too wordy, but I would argue changing that to ```diff - LSTR MSG_XATC_UPDATE_Z_OFFSET = _UxGT("Update Probe Z-Offset to "); +...

Follow up to "🚸 Update ProUI Plot graph (#26539)"

> You'll need to rename Icon number 44 in the various icon packs from `ICON_ResumeEEPROM` to `ICON_ResetEEPROM`. I suppose you mean within this **PR** [here, Configurations #994](https://github.com/MarlinFirmware/Configurations/pull/994)? Redoing each one...

Follow up to "🚸 Update ProUI Plot graph (#26539)"

> What is the procedure to prepare icons 93, 200-206, and 250-254 ? and do these only pertain to TJC? We should add these to `buildroot/share/dwin` for completeness with our...

Follow up to "🚸 Update ProUI Plot graph (#26539)"

> I've updated the contents of the `buildroot/share/dwin` folder, so it should now have everything needed to generate the numbered ICO files for sets 3, 4, and 7. If there's...

Follow up to "🚸 Update ProUI Plot graph (#26539)"

question: is there a way to make this work for all languages? besides placing this in every **language_xx.h** file, since they are `using namespace Language_en;` anyway... take the following in...

Follow up to "🚸 Update ProUI Plot graph (#26539)"

you know the change in "[remove non-translated atoms](https://github.com/MarlinFirmware/Marlin/pull/26563/commits/620aa67b4ff2b31eeb44014b4ec56f227a924f2a)", commit [620aa67](https://github.com/MarlinFirmware/Marlin/pull/26563/commits/620aa67b4ff2b31eeb44014b4ec56f227a924f2a) how about making that a language string?: ```y LSTR MSG_PID_SET_KP = _UxGT("Set" STR_KP); LSTR MSG_PID_SET_KI = _UxGT("Set" STR_KI); LSTR MSG_PID_SET_KD...

Follow up to "🚸 Update ProUI Plot graph (#26539)"

> it looks like basic language support with string substitution is still incomplete in ProUI. Hopefully that will be added pretty soon. In the meantime we'll just retain the current...

Follow up to "🚸 Update ProUI Plot graph (#26539)"

>So they just need to be added to the DACAI private set and tjc.tft. >I can go ahead and put the new JPEG files into the private folder, but I'm...