Andrew

Results 101 comments of Andrew

> I think there comes a point where it's no longer "Pro UI by MRiscoC" if code has diverged so far that they can't be reconciled you're thinking it the...

> > you're thinking it the other way around. there's "MRiscoC's ProUI" and there's "Marlin's ProUI" > > No, we literally call it out as "Pro UI by MRiscoC" since...

> @classicrocker883 can you explain why this option is useful? Is there something unique to ProUI that makes it more likely to need an encoder reversal that other types of...

@ellensp should this be instead? ```diff EncoderState encoderReceiveAnalyze() { for (uint8_t i = 0; i < LED_NUM; i++) { LED_DataArray[i] = 0; switch (RGB_Scale) { - case RGB_SCALE_R10_G7_B5: LED_DataArray[i] =...

@thinkyhead hey I was able to fix the issue when starting ProUI with ExtUI by "reverting" `SETUP_RUN()` in **MarlinCore.cpp**, but there is something peculiar to note: when testing and first...

> @classicrocker883 do you think you could re-post these as individual changes that have the narrowest scope possible? Ideally there isn't a lot of `and` in the description. > >...

> OK, let me try to phrase this in a different way. > > Your description mentions reverting one change in one file. Your PR is touching 19 files, and...

you know you didnt have to close this. I am editing it now. wtf?

> I would recommend one small targeted PR that fixes the regression you mentioned in SETUP_RUN, then follow-up PRs changing other things. I dont think you understand the code how...

they are all related to this previous **PR** that was merged. so instead of splitting each change, its better to keep them all in one because they are all equally...