Marlin icon indicating copy to clipboard operation
Marlin copied to clipboard

Wrong menu text for adjusting Z probe offset

Open abortz opened this issue 1 year ago • 2 comments

Fix the text on the Z probe offset menu item in ProUI. The current one (recently changed) is verbose and overflows the space in the UI. The old one was perfect.

abortz avatar Mar 02 '24 19:03 abortz

I agree "Update Probe Z-Offset to " is a bit too wordy, but I would argue changing that to

- LSTR MSG_XATC_UPDATE_Z_OFFSET           = _UxGT("Update Probe Z-Offset to ");
+ LSTR MSG_XATC_UPDATE_Z_OFFSET           = _UxGT("Update Z-Offset");

or just make a new MSG_:

+ LSTR MSG_UPDATE_Z_OFFSET           = _UxGT("Update Z-Offset");

classicrocker883 avatar Mar 03 '24 01:03 classicrocker883

@classicrocker883 this is the same text used by a half dozen different UIs. Changing it seems like a topic for a different issue/PR.

@thinkyhead this seems like an easy revert -- the text string you switched to appears only to be used by an X Axis Twist wizard.

abortz avatar Mar 03 '24 01:03 abortz

@abortz would you be able to link to the commit that changed the behavior you are reverting? If you could readily provide pictures of the before and after behavior that would be fantastic. Thanks.

sjasonsmith avatar Apr 07 '24 05:04 sjasonsmith

Looks like it was 0f0955492994f4a7f4649c22e0f3aa5cc71541d7

Attached is an after photo, I don't have a before but the text was way too long and clipped. PXL_20240407_155450101

abortz avatar Apr 07 '24 15:04 abortz