chriseth

Results 231 comments of chriseth

Can you add some more tests for the following cases, please? - `using {a.b.f as +} for Int;` - you need multiple files for that where you have `import "b.sol"...

I'm a bit worried that this does not improve gas costs. It is understandable since we do not really change much for types larger than 128 bits. The SafeMath library...

This is looking really good already! We have to be careful to find a good balance between this being generic enough and not too complicated, but I would suggest the...

I'm not sure if that was already your reason for the relative offsets, but if we use relative offsets and can ensure them to be at most 256, we can...

Can you squash to a single commit, please?

No, squash-merging is a different thing. You have to rebase your own fork interactively (`git rebase -i origin/develop`) and then use "squash" on the second commit. After that you have...

Is the yul mode for remix working for this case?

The main idea of the restricted rules was to eliminate subtraction to bring all arithmetics into a normal form that uses as little subtraction as possible. It would be nice...

It might be the best solution to introduce new builtins that do not write to memory and replace them in a new optimizer step. Note that since the memory-modifying instructions...

On the other hand - we also want to detect if such an opcode writes to a memory area that is not overlapping with other known memory areas, so it...