chriseth

This could be combined with the `Operations` from #11352

Just a comment on the name of the modifier: I don't like opinionated words like "safe" or "protected" because they give a false impression of safety or protection, we should...

Thank you for the pull request! I fear that the complete solution is a bit more complicated. Can you just ignore all the cases after the `else if (m_inBranch)`?

The main issue I have with this PR is that I'm not convinced that it properly detects multiple writes to a variable in the same branch. Reporting the error about...

The main issue I have with this PR is that I'm not convinced that it properly detects multiple writes to a variable in the same branch. Reporting the error about...

Does this need updated documentation?

Is there an optimizer step that might be more fitting? Structural sounds more like it operates on the structure of the code...

> I didn't see anything obvious... the expression simplifier only acts on expressions and can't easily add the `pop`... and the structural simplifier already has the literal rematerializer as soft-requirement,...

Yep, that's exactly it. So it looks like for CSE we should disable m_memory and m_storage in DataFlowAnalyzer and we should use a more efficient data structure for the search...

@leonardoalt do you still have the original input for the profiler run here?